Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added more server function #1320

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Added more server function #1320

wants to merge 2 commits into from
+124 −11

Conversation

canerksk
Copy link
Contributor

@canerksk canerksk commented Oct 25, 2024 •
edited
Loading

f_onserver_mode

f_onserver_resync_start
f_onserver_resync_restart
f_onserver_resync_failed
f_onserver_resync_success
f_onserver_resync_finish

f_onserver_save_stage
f_onserver_save_force
f_onserver_save_try

Issue #1295

@canerksk
Added more server function
0cfc874 
f_onserver_mode

f_onserver_resync_start
f_onserver_resync_restart
f_onserver_resync_failed
f_onserver_resync_success
f_onserver_resync_finish

f_onserver_save_stage
f_onserver_save_force
f_onserver_save_try
@canerksk
missing scope added.
7e10a2c
@cbnolok
Copy link
Contributor

cbnolok commented Nov 27, 2024

  • Could you explain better when is f_onserver_resync_restart called? Only when resuming from a resync pause?
  • Isn't f_onserver_resync_finish redundant, since we have success and failed?
  • I'd also explain more precisely to users the difference between f_onserver_save_stage, force and try.
  • I'd rename f_onserver_mode to f_onserver_mode_change, if you don't mind.
  • It looks also that there's f_onserver_exit_later, not documented in the changelog. Why should that be needed when we already have f_onserver_exit? Only for having the exitflag? Be wary that doing scripted stuff at that stage will make the server crash in a ton of cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@canerksk @cbnolok